Align ValueEntity with EventSourcedEntity #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ValueEntityHandler and ValueEntitiesImpl more similar to corresponding event sourced implementations * change state management in handler and impl * no emptyState in the handler * remove AnnotationBasedValueEntitySupport and annotations * update ValueEntitiesImplSpec with Java impl of ShoppingCart (taken from sample)
patriknw
commented
Aug 26, 2021
sdk/src/main/scala/com/akkaserverless/javasdk/impl/valueentity/ValueEntitiesImpl.scala
Show resolved
Hide resolved
octonato
approved these changes
Aug 26, 2021
sdk/src/main/java/com/akkaserverless/javasdk/valueentity/ValueEntityBase.java
Show resolved
Hide resolved
sdk/src/main/scala/com/akkaserverless/javasdk/impl/valueentity/ValueEntitiesImpl.scala
Outdated
Show resolved
Hide resolved
sdk/src/main/scala/com/akkaserverless/javasdk/impl/valueentity/ValueEntitiesImpl.scala
Show resolved
Hide resolved
octonato
approved these changes
Aug 26, 2021
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event sourced implementations
(taken from sample)
Refs #52