Effect API+impl for actions #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
patriknw
reviewed
Sep 1, 2021
sdk/src/main/java/com/akkaserverless/javasdk/action/Action.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/akkaserverless/javasdk/action/Action.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/akkaserverless/javasdk/action/Action.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/com/akkaserverless/javasdk/action/Action.java
Outdated
Show resolved
Hide resolved
|
Done for final review |
octonato
approved these changes
Sep 1, 2021
Comment on lines
+118
to
+125
| /** | ||
| * Create a reply from an async operation result returning an effect. | ||
| * | ||
| * @param futureEffect The future effect to reply with. | ||
| * @return A reply, the actual type depends on the nested Effect. | ||
| * @param <S> The type of the message that must be returned by this call. | ||
| */ | ||
| <S> Effect<S> asyncEffect(CompletionStage<Effect<S>> futureEffect); |
There was a problem hiding this comment.
Not clear to me in which case we would need this one.
There was a problem hiding this comment.
Look at the TCK Action. I thought it felt superficial at first but I think it makes sense that any effect and its side effects, not only messages, can be created as a consequence of a future completing.
Comment on lines
51
to
52
| // FIXME async + closing over stateful action context will be a pain for users | ||
| ActionContext actionContext = actionContext(); |
|
The two FIXMEs in |
octonato
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #52
Effects API for actions and implementation plus codegen.
Old Reply type left in place even though Actions does not use it anymore since replicated entities still does.