Integrate maven-java into CI build #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
force-pushed
the
rgc/include-maven-plugin-in-ci
branch
from
adcf2a5
to
e210a0e
Compare
octonato
force-pushed
the
rgc/include-maven-plugin-in-ci
branch
from
40def82
to
b303374
Compare
7 tasks
octonato
commented
Jun 16, 2021
Comment on lines
+181
to
+183
| mvn -B archetype:generate -DgroupId=com.example -DartifactId=counter-event-sourced-entity -DarchetypeGroupId=com.lightbend -DarchetypeArtifactId=maven-archetype-akkasls-event-sourced-entity -DarchetypeVersion=$SDK_VERSION | ||
| cd counter-event-sourced-entity | ||
| mvn -B -Dakkaserverless-sdk.version=$SDK_VERSION compile |
There was a problem hiding this comment.
I'm taking a different approach here than the original build GH Action. The original build was deploying the proxy, the user service and then hitting it with curl.
I confess, that the main reason that I'm not reproducing it here is because it's a little more complicated to do it in CircleCI. I could have tried harder, but at this stage I'm taking a shortcut. I prefer to move faster with the merge of the projects.
Also, I believe we will be better served if we use the integration test testkit with a fully implement application and this is something I would like to add once we move the codegen under the SDK project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.