fix: use com.akkaserverless groupId and renamed artifacts #45
Conversation
| @@ -1,11 +1,11 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <modelVersion>4.0.0</modelVersion> | |||
|
|
|||
| <artifactId>maven-archetype-akkasls-event-sourced-entity</artifactId> | |||
| <artifactId>akkaserverless-maven-archetype-event-sourced-entity</artifactId> | |||
There was a problem hiding this comment.
| <artifactId>akkaserverless-maven-archetype-event-sourced-entity</artifactId> | |
| <artifactId>maven-archetype-event-sourced-entity</artifactId> |
As we get akkaserverless in the group ID, we could drop it from the artifact ID.
There was a problem hiding this comment.
Yeah, we said it on the call, but when changing it I found it would be better to keep it. Mainly because of the value-entity one. It feels a bit naked if only maven-archetype for the default one.
But I agree that we are being repetitive when saying com.akkaserverless:akkaserverless-maven-archetype
There was a problem hiding this comment.
An alternative could be the following:
starter for the the default one
(uses value-entity)
mvn archetype:generate \ <rgc/rename-artifacts-for-publishing>
-DarchetypeGroupId=com.akkaserverless \
-DarchetypeArtifactId=maven-project-starter \
-DarchetypeVersion=LATEST
and then...
mvn archetype:generate \ <rgc/rename-artifacts-for-publishing>
-DarchetypeGroupId=com.akkaserverless \
-DarchetypeArtifactId=maven-project-event-sourced-entity \
-DarchetypeVersion=LATEST
Then, later on, if we decide that the default is without any proto file, we can keep the name maven-project-starter and we add another one called maven-project-value-entity.
There was a problem hiding this comment.
Let's stick to archetype as that is Maven-speak.
We should not introduce another thing like "starter". "kickstart" would align with what we use in the docs right now, but it has been questioned if that is a good word.
I don't see a problem with the naked "maven-archetype", actually.
There was a problem hiding this comment.
shall we also remove akkaserverless from akkaserverless-maven-plugin?
that will make:
com.akkaserverless % maven-plugin
com.akkaserverless % maven-archetype
com.akkaserverless % maven-archetype-event-sourced-entity
There was a problem hiding this comment.
Yes, that should appeal to your need for consistency. ;-)
There was a problem hiding this comment.
well, unfortunately that won't work
Artifact Ids of the format maven-___-plugin are reserved for
plugins in the Group Id org.apache.maven.plugins
Please change your artifactId to the format ___-maven-plugin
In the future this error will break the build.
plugins starting with maven- are reserved
Co-authored-by: Enno Runne <458526+ennru@users.noreply.github.com>
octonato
force-pushed
the
rgc/rename-artifacts-for-publishing
branch
from
b8a8446
to
0e1edff
Compare
No description provided.