Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build publish maven plugin from CI to sonatype #65

Merged
merged 38 commits into from
Jun 25, 2021

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jun 24, 2021

towards #27

@raboof raboof requested a review from octonato June 24, 2021 14:45
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://s01.oss.sonatype.org</nexusUrl>
<autoReleaseAfterClose>false</autoReleaseAfterClose>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could set this to 'true' eventually, but for the first release perhaps let's give ourselves a chance to check the artifacts?

@raboof raboof marked this pull request as ready for review June 24, 2021 14:48
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

command: |
cd maven-java
echo $PGP_SECRET | base64 -d | gpg --import --batch
# It seems ~/.m2 is not actually restored from the cache?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate it further. We may be doing something wrong.

When I was bringing the maven code here, I was surprised to see that I have to call sbt publishM2 more then once in the same CI build. I was planning to call only once and reuse the local artifacts on the next jobs. Didn't work as expected.

@octonato octonato merged commit 29a4297 into rgc/feature-branch-maven-java Jun 25, 2021
@octonato octonato deleted the mvn-publish-to-sonatype branch June 25, 2021 13:04
@octonato
Copy link
Member

hmm, I could have squashed before merging. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants