-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build publish maven plugin from CI to sonatype #65
build publish maven plugin from CI to sonatype #65
Conversation
7982bd2
to
cb284c5
Compare
So we only have to do it when publishing
<configuration> | ||
<serverId>ossrh</serverId> | ||
<nexusUrl>https://s01.oss.sonatype.org</nexusUrl> | ||
<autoReleaseAfterClose>false</autoReleaseAfterClose> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could set this to 'true' eventually, but for the first release perhaps let's give ourselves a chance to check the artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
command: | | ||
cd maven-java | ||
echo $PGP_SECRET | base64 -d | gpg --import --batch | ||
# It seems ~/.m2 is not actually restored from the cache? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to investigate it further. We may be doing something wrong.
When I was bringing the maven code here, I was surprised to see that I have to call sbt publishM2 more then once in the same CI build. I was planning to call only once and reuse the local artifacts on the next jobs. Didn't work as expected.
hmm, I could have squashed before merging. 🤦 |
towards #27