Refactor Value Entity to use codegen #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
commented
May 31, 2021
.circleci/config.yml
Outdated
Comment on lines
208
to
211
| - samples-tests: | ||
| filters: # required since publish jobs have tag filters and dependencies | ||
| tags: | ||
| only: /.*/ |
.circleci/config.yml
Outdated
Comment on lines
150
to
153
| sbt publishM2 | ||
| export SDK_VERSION=`sbt sdk/version | tail -n 1 | cut -c8-100` | ||
| cd samples/java-valueentity-shopping-cart | ||
| mvn -Dakkaserverless-sdk.version=$SDK_VERSION clean verify -Pit |
There was a problem hiding this comment.
Still very hacky.
It's annoying to publishM2 for each sample test.
I need to test further, but an alternative is to have job that creates a version.sbt fixing the version to some build id from CircleCI. We run publishM2 once and we run the other sample jobs using the same fixed version.
octonato
force-pushed
the
rgc/codegen-value-entity-sample
branch
from
35c0afa
to
1738119
Compare
|
This is ready for review, but not for immediate merge. Merging this will probably break the docs since it touches the example used for the Value Entity. I will keep refactoring the other samples and will send PRs on top of this one. |
This was referenced Jun 1, 2021
|
Superseded by #10 |
octonato
pushed a commit
that referenced
this pull request
Jun 11, 2021
Introduces CD and depends on published codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet to merge since docs are referencing the samples.
TODO