Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MiMa sbt plugin tell you which artifact/project it is processing #6

Closed
bantonsson opened this issue May 24, 2012 · 6 comments
Closed

Comments

@bantonsson
Copy link
Contributor

Output if I in akka do mima-report-binary-issues from the top level (only akka-actor and akka-testkit have been configured)

mima-report-binary-issues
[info] Resolving com.typesafe.akka#akka-actor;2.0 ...
[info] Resolving org.scala-lang#scala-library;2.9.1-1 ...
[info] Resolving com.typesafe.akka#akka-testkit;2.0 ...
[info] Resolving com.typesafe.akka#akka-actor;2.0 ...
[info] Resolving org.scala-lang#scala-library;2.9.1-1 ...
[info] Found 17 potential binary incompatibilities
[error] * class akka.actor.ReceiveTimeout was concrete; is declared abstract in new version
< SNIP SNAP >
[error] * class akka.routing.CurrentRoutees was concrete; is declared abstract in new version
[info] Found 0 potential binary incompatibilities

Kind of hard to see what's ok and what's not.

@viktorklang
Copy link

How can it be an error and then reported as 0 problems?

@bantonsson
Copy link
Contributor Author

The first [info] is akka-actor, and the second [info] is akka-testkit. Isn't it obvious?

@viktorklang
Copy link

I don't think it's obvious that the following is outputted:

[error] * class akka.routing.CurrentRoutees was concrete; is declared abstract in new version

and then it says:

[info] Found 0 potential binary incompatibilities

How can something be an error, but not something that needs fixing?

@bantonsson
Copy link
Contributor Author

That's the meaning of this ticket.

If the output had looked something like this:

mima-report-binary-issues
[info] Resolving com.typesafe.akka#akka-actor;2.0 ...
[info] Resolving org.scala-lang#scala-library;2.9.1-1 ...
[info] Resolving com.typesafe.akka#akka-testkit;2.0 ...
[info] Resolving com.typesafe.akka#akka-actor;2.0 ...
[info] Resolving org.scala-lang#scala-library;2.9.1-1 ...
[info] akka-actor: Found 17 potential binary incompatibilities
[error] * class akka.actor.ReceiveTimeout was concrete; is declared abstract in new version

[error] * class akka.routing.CurrentRoutees was concrete; is declared abstract in new version
[info] akka-testkit: Found 0 potential binary incompatibilities

It would make more sense

@viktorklang
Copy link

Or simply:

[error] [akka-actor] [major] * class akka.actor.ReceiveTimeout was concrete; is declared abstract in new version

@bantonsson
Copy link
Contributor Author

Yes, that would be fine as well, but there needs to be an output when it is ok that contains the name as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants