Produce a better error message when files are found that cannot be processed #238
Conversation
| val lines = try { | ||
| Source.fromFile(file).getLines().toVector | ||
| } catch { | ||
| case t: Throwable => throw new RuntimeException(s"Couldn't load '$file'") |
There was a problem hiding this comment.
Could you add the original Throwable as the cause (to avoid swallowing the stack)?
Also, can we be more selective on what throwables to catch?
There was a problem hiding this comment.
👍 on adding the original Throwable.
Not sure if we want to be more selective: the error I had a hard time tracking down was an java.nio.charset.MalformedInputException. I guess we could catch java.io.IOException explicitly, but I'd say this catch is useful whatever the exception.
There was a problem hiding this comment.
What about those pesky fatal errors?
There was a problem hiding this comment.
I'd say those are unlikely to be caused by any particular file and so it'd be fine to let those bubble up without getting in the way (and causing allocations etc)? Would be happy to include them if you prefer though.
There was a problem hiding this comment.
Sorry, I meant should we avoid trying to handle them? e.g should we use NonFatal?
Anyways we can always forward-fix.
There was a problem hiding this comment.
Ah, quite right, will update!
No description provided.