Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly classify incompatible result types of overridden methods #460

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Correctly classify incompatible result types of overridden methods #460

merged 2 commits into from
Feb 4, 2020

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Feb 4, 2020

Partly reverting b58ed45

Refs #459

dwijnand
dwijnand approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of can't load into my brain what I was doing in b58ed45. I seem to remember a test case I think @lrytz shared with me where an overload was dropped and it was confusingly saying "result type mismatch". But it seems I didn't add a test for that, and I introduced a bug, so:

LGTM, and thanks!!

@dwijnand dwijnand added this to the 0.6.4 milestone Feb 4, 2020
@dwijnand dwijnand linked an issue Feb 4, 2020 that may be closed by this pull request
IncompatibleResultTypeProblem reported as DirectMissingMethodProblem #459
Closed
@mergify mergify bot merged commit bf742f6 into master Feb 4, 2020
@mergify mergify bot deleted the incompatibleResultType branch February 4, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
merge-when-green
Milestone
0.6.4
Development

Successfully merging this pull request may close these issues.

IncompatibleResultTypeProblem reported as DirectMissingMethodProblem
2 participants
@raboof @dwijnand