This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
fix implcit conversion of Resolver #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was not working because the implicit type conversion method was not defined in the same object as the class being implicitly converted. Therefore, scala could not find the implicit method when the forBucket method was called In addition, refactor code and clean up warnings
|
@nayakravi The PR have failed the CLA validation step |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was not working because the implicit type
conversion method was not defined in the same object as the class
being implicitly converted. Therefore, scala could not find the
implicit method when the forBucket method was called
In addition, update sbt version number and refactor some code
Fix for: #4