Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Java 11 #98

Closed
wsargent opened this issue Aug 20, 2018 · 7 comments · Fixed by #138
Closed

Support Java 11 #98

wsargent opened this issue Aug 20, 2018 · 7 comments · Fixed by #138
Milestone

Comments

@wsargent
Copy link
Contributor

Should see how to work the Unsafe shenanigans into JDK 1.9 safely, and establish migration path.

scala/scala-dev#139

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 2, 2018

compile error with JDK11

def matchKerberos(hostname: String, principal: Principal) = HostnameChecker.`match`(hostname, principal.asInstanceOf[KerberosPrincipal])

Welcome to Scala 2.12.7 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_181).
Type in expressions for evaluation. Or try :help.

scala> sun.security.util.HostnameChecker.`match` _
res0: (String, java.security.Principal) => Boolean = $$Lambda$1047/225753796@5ff90645
Welcome to Scala 2.12.7 (Java HotSpot(TM) 64-Bit Server VM, Java 11).
Type in expressions for evaluation. Or try :help.

scala> sun.security.util.HostnameChecker.`match` _
<console>:12: error: value match is not a member of object sun.security.util.HostnameChecker
       sun.security.util.HostnameChecker.`match` _
                                         ^

@dwijnand
Copy link
Member

dwijnand commented Oct 2, 2018

@dwijnand
Copy link
Member

dwijnand commented Oct 2, 2018

@SethTisue
Copy link
Member

see #100

@SethTisue
Copy link
Member

@dwijnand @ignasi35 this is now the top blocker (blocking the most downstream projects) in the Scala community build on JDK 11

@dwijnand dwijnand changed the title Support Java 9 Support Java 11 Oct 18, 2018
@dwijnand
Copy link
Member

OK, I'll negotiate for it to be part of the next sprint.

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 23, 2018

https://hg.openjdk.java.net/jdk/jdk11/rev/68fa3d4026ea#l165.29

The match method removed due to TLS 1.3 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants