Decomission DefaultHostnameVerifier

[dwijnand]

Upstream playframework/playframework@f35dd09

Fixes #98 (verified test:compile succeeds locally)
Fixes #100

[SethTisue]

MiMa is squawking

[dwijnand]

It's not wrong ;-)

[SethTisue]

MiMa is annoying that way

[SethTisue]

in the Scala community build this causes

[akka-stream] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.16/project-builds/akka-stream-fe1d9d022b8160be9527102bfb64d1e77c200315/akka-stream/src/main/scala/com/typesafe/sslconfig/akka/AkkaSSLConfig.scala:113:61: not found: type DisabledComplainingHostnameVerifier
[akka-stream] [error]       if (config.loose.disableHostnameVerification) classOf[DisabledComplainingHostnameVerifier].asInstanceOf[Class[HostnameVerifier]]
[akka-stream] [error]                                                             ^
[akka-stream] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.16/project-builds/akka-stream-fe1d9d022b8160be9527102bfb64d1e77c200315/akka-stream/src/main/scala/com/typesafe/sslconfig/akka/AkkaSSLConfig.scala:114:19: value hostnameVerifierClass is not a member of com.typesafe.sslconfig.ssl.SSLConfigSettings
[akka-stream] [error]       else config.hostnameVerifierClass.asInstanceOf[Class[HostnameVerifier]]
[akka-stream] [error]                   ^

[marcospereira]

Should we add oraclejdk11 to Travis configuration?

[SethTisue]

trying it: scala/community-build@2606f80

[wsargent]

You'll want to remove the debug section from the docs (or add a note) to reflect the package removal

[dwijnand]

Good idea, @wsargent. Do you mind reviewing if I dropped too much?

[wsargent]

@dwijnand I don't have review rights :-)

Maybe add a warning if ssl-config.debug is defined in config (since it no longer does anything) and refer to https://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/ReadDebug.html as the main debugging reference?

[dwijnand]

Thanks, Will. Done.

(Btw, anyone in GitHub can review pull requests 🙂)

[wsargent]

@dwijnand https://github.com/tersesystems/debugjsse and https://github.com/tersesystems/ocapjsse#logging are better debugging solutions anyway -- I can open up a PR to have them map to the debug config and preserve functionality without the hacks...

[SethTisue]

trying it: scala/community-build@2606f80

green at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk11-integrate-community-build/138/

[dwijnand]

Sounds good to me, @wsargent.

Excellent. Thanks, @SethTisue.

[marcospereira]

LGTM.

[SethTisue]

@dwijnand in the Scala 2.12 community build at e.g. https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3722/ , play-ws is now failing because DebugConfiguration vanished. could I convince you to submit a small play-ws PR that fixes it...?

(I don't know the code, but perhaps an alternative would be to reintroduce DebugConfiguration here in this repo but as a deprecated no-op?)

[dwijnand]

Damn. Just for context, the reason I dropped it is because it doesn't run on Java 11, as it's using privileged reflection actions, that are now enforced by the JVM (IIUC).

So I wonder how much play-ws actually depends on the behaviour of DebugConfiguration...

I'll get back to this when I'm done travelling.

[SethTisue]

thanks. it was easy to get the community build green again for now with SethTisue/play-ws@a99b2b6 and scala/community-build@bb8b9d2

[SethTisue]

er, well, except for:

[playframework] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.16/project-builds/playframework-336d962b6fcd9f1f9964169addd9c496e6290d3f/framework/src/play-ahc-ws/src/main/scala/play/api/libs/ws/ahc/AhcWSModule.scala:15: object debug is not a member of package com.typesafe.sslconfig.ssl
[playframework] [error] import com.typesafe.sslconfig.ssl.debug.DebugConfiguration
[playframework] [error]                                   ^
[playframework] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.16/project-builds/playframework-336d962b6fcd9f1f9964169addd9c496e6290d3f/framework/src/play-ahc-ws/src/main/scala/play/api/libs/ws/ahc/AhcWSModule.scala:71: not found: type DebugConfiguration
[playframework] [error]       new DebugConfiguration(loggerFactory).configure(wsClientConfig.ssl.debug)
[playframework] [error]           ^
[playframework] [error] two errors found
[playframework] [error] (Play-AHC-WS/compile:compileIncremental) Compilation failed

SethTisue/playframework@747409c
scala/community-build@b4c8d93

[dwijnand]

Opened #142 to restore the debug packages.