New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Javascript unit tests in maven build (fixes #39) #52
Run Javascript unit tests in maven build (fixes #39) #52
Conversation
Conflicts: data-mgmt/pom.xml
Should be noted that there are unfortunately no JS unit tests... yet. But this is the infrastructure to run them within CI. |
Also, as you can see the bower-downloaded dependencies are currently checked into source control. This is because bower does not yet have a version "freeze" or "shrinkwrapping" feature (bower/bower#505) so the next best thing, though ugly, is checking dependencies into source control so the exact versions of dependencies are managed. |
Seems very nice, wasn't it possible to add the dependencies on .gitignore or something? Are you planning to add more things to this PR (maybe the tests or anything else)? Let me know so I can finish to review it and merge. Thanks =) |
Also, the repository is out sync with the master remote branch, so it would be nice to merge it. |
I'll get this up to date Unfortunately dependencies actually need to be in source control. There is an issue open to resolve this I believe |
@alechenninger any chance you can get this in a state it can be merged? |
Conflicts: data-mgmt/src/main/webapp/bower.json
Changes Unknown when pulling 71b5d8d on alechenninger:unit-tests into * on lightblue-platform:master*. |
Run Javascript unit tests in maven build (fixes #39)
This makes mvn clean test download node, npm, then download test dependencies, then run the unit tests against the javascript code. Unit tests are placed in src/test/webapp (to mirror src/main/webapp).
Libraries used: