Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response for error status codes (fixes #66) #87

Merged
merged 1 commit into from Apr 8, 2015

Conversation

alechenninger
Copy link
Contributor

#66

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.22% when pulling 56391cf on alechenninger:handle-errors into 74ae58c on lightblue-platform:master.

@dcrissman
Copy link
Member

Change seems simple enough. Is there anyway I could test this?

@alechenninger
Copy link
Contributor Author

You can download the app and deploy it. If you have a static http server available (I think python comes with SimpleHTTPServer, ie python -m SimpleHTTPServer 8000), you can just serve up the src/main/webapp directory and use that.

There aren't many tests for this app right now unfortunately, haven't had time to add any.

This is essential for the next release to prod, the app is kind of broken without it. I saw the versions were just bumped for this repo. Does that mean this won't get into the next release?

@dcrissman
Copy link
Member

Thanks @alechenninger I was able to test in the way you described. Looks good, so I will merge.

dcrissman added a commit that referenced this pull request Apr 8, 2015
Update response for error status codes (fixes #66)
@dcrissman dcrissman merged commit 38eaf1f into lightblue-platform:master Apr 8, 2015
@dcrissman
Copy link
Member

The issue #66 was marked for the Bill release, so unfortunately this did not get in before Ana was cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants