Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15: removes dependency on lightblue-rest #16

Merged
merged 2 commits into from Nov 12, 2014

Conversation

jewzaam
Copy link
Member

@jewzaam jewzaam commented Nov 11, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.86%) when pulling 9fbfeba on jewzaam:remove_rest_dependency into 418562d on lightblue-platform:master.

@luan-cestari
Copy link
Collaborator

I think I got the point of the change you made but don't you think it would be better to centralize the way we access the configuration instead making this projects know low level stuff (which could bring a lot of trouble if we change it)? I would suggest to move the root of the dependency to more low level (to the core repository), so any project above would have agnostic access to it.

@jewzaam
Copy link
Member Author

jewzaam commented Nov 12, 2014

Please add an issue for that. This change is required for the 1.1 release and while it would be nice to have central management, we have external factors driving a need for release.

@jewzaam
Copy link
Member Author

jewzaam commented Nov 12, 2014

FYI added a new commit to update core and mongo deps to latest snapshots.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.86%) when pulling 6ff2bb5 on jewzaam:remove_rest_dependency into 418562d on lightblue-platform:master.

derek63 added a commit that referenced this pull request Nov 12, 2014
Fixes #15: removes dependency on lightblue-rest
@derek63 derek63 merged commit d6228e2 into lightblue-platform:master Nov 12, 2014
@jewzaam jewzaam deleted the remove_rest_dependency branch November 12, 2014 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants