Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hystrix dependencies to be managed transiently #49

Merged
merged 2 commits into from Jun 12, 2015

Conversation

dcrissman
Copy link
Member

@coveralls
Copy link

Coverage Status

Coverage decreased (-92.86%) to 0.51% when pulling da85e4e on dcrissman:fix-hystrix into 4f5b861 on lightblue-platform:master.

@luan-cestari
Copy link
Collaborator

It seems that not all those dependencies was reachable during the test at least. The travis got a lot of errors like this one : java.lang.NoSuchMethodError: com.netflix.hystrix.HystrixCommand$ObservableCommand.toBlockingObservable()Lrx/observables/BlockingObservable;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.37% when pulling 2fb4944 on dcrissman:fix-hystrix into 4f5b861 on lightblue-platform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.37% when pulling 2fb4944 on dcrissman:fix-hystrix into 4f5b861 on lightblue-platform:master.

@dcrissman
Copy link
Member Author

@luan-cestari fixed. I think that error had to do with some existing bad artefacts.

paterczm added a commit that referenced this pull request Jun 12, 2015
allow hystrix dependencies to be managed transiently
@paterczm paterczm merged commit 6411ee3 into lightblue-platform:master Jun 12, 2015
@dcrissman dcrissman deleted the fix-hystrix branch June 12, 2015 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants