Prevent generator api from being used in bulk request #293
Conversation
| @@ -17,6 +17,6 @@ | |||
|
|
|||
| LightblueBulkDataResponse bulkData(AbstractDataBulkRequest<AbstractLightblueDataRequest> requests) throws LightblueException; | |||
|
|
|||
| <T> T data(AbstractLightblueDataRequest lightblueRequest, Class<T> type) throws LightblueException; | |||
| <T> T data(LightblueRequest lightblueRequest, Class<T> type) throws LightblueException; | |||
There was a problem hiding this comment.
I feel strongly that the data api should be locked down to AbstractLightblueDataRequest implementations.
There was a problem hiding this comment.
I don't agree. Then there should be two interfaces, and two methods. Having
an interface, and then requiring the abstract implementation of it is ugly.
On Mon, May 16, 2016 at 7:00 PM, Dennis Crissman notifications@github.com
wrote:
In core/src/main/java/com/redhat/lightblue/client/LightblueClient.java
#293 (comment)
:@@ -17,6 +17,6 @@
LightblueBulkDataResponse bulkData(AbstractDataBulkRequest<AbstractLightblueDataRequest> requests) throws LightblueException;
- T data(AbstractLightblueDataRequest lightblueRequest, Class type) throws LightblueException;
- T data(LightblueRequest lightblueRequest, Class type) throws LightblueException;
I feel strongly that the data api should be locked down to
AbstractLightblueDataRequest implementations. The method is not designed to
work with other types of implementations.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/lightblue-platform/lightblue-client/pull/293/files/6ba57d62c328c422cf8891eca563e7ca7de8bac8#r63451488
There was a problem hiding this comment.
AbstractLightblueDataRequest is the parent of all the data request objects implemented in the lightblue client. Specifically it knows how to build the rest uri.
|
What if we created a marker interface that extended LightblueRequest for requests that can be bulk packaged? Say WithBulkSupport or something? Then the DataBulkRequest could only accept only requests with that interface? |
|
+1 On Mon, May 16, 2016 at 7:06 PM, Dennis Crissman notifications@github.com
|
| return null; | ||
| } | ||
| return body.toString(); | ||
| public JsonNode getBodyJson() { |
There was a problem hiding this comment.
abstract, instead of return null? could be, but then I have to implement it
in all the concrete classes.
On Fri, May 20, 2016 at 12:19 PM, Dennis Crissman notifications@github.com
wrote:
In
core/src/main/java/com/redhat/lightblue/client/request/AbstractLightblueMetadataRequest.java
#293 (comment)
:@@ -36,14 +54,7 @@ public String getRestURI(String baseServiceURI) {
}@Override
- public String getBody() {
JsonNode body = getBodyJson();if (body == null) {return null;}return body.toString();- public JsonNode getBodyJson() {
abstract?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/lightblue-platform/lightblue-client/pull/293/files/a26850a67fc0252d7f24a09ecf4c45fd80b40b2f#r64085150
|
Not merging per @bserdar's request, but +1 to this change. |
|
@bvulaj , please take a look at the changes to bulk requests |
|
I like the changes. Since there are compatibility concerns, please remember to bump the version, even if it's SNAPSHOT (not seeing version bump in the diff). |
|
Version bumped. On Tue, May 24, 2016 at 8:34 AM, Marek notifications@github.com wrote:
|
No description provided.