-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueGenerators parsing and json schema changes #431
Conversation
Uid fields are generated by UIDInterceptor. I think we can use interceptor for generating other values too, relaying on a db specific extension (similar to how LockingSupport extension). |
So: a constraint that associates a sequence name with a field, and an On Tue, Aug 4, 2015 at 4:32 AM, Marek notifications@github.com wrote:
|
Yes, except it's not a constraint, it's a generator (new keyword). |
Ok, saw that. In that case, you have to change SimpleField as well, add generators to it. On Tue, Aug 4, 2015 at 8:02 AM, Marek notifications@github.com wrote:
|
Why SimpleField and not Field? Field has constraints, so I would think it should have value generators as well. |
If you add to Field, then arrays and objects will have generators as well, On Mon, Aug 17, 2015 at 6:07 AM, Marek notifications@github.com wrote:
|
Since we decided to use backend functionality to handle the sequence, I don't think the interceptor is needed. Value will be generated by the database and sequence defined by lightblue-mongo (or other backend with sequence support). For the same reason did not make any changes in LightblueFactory. Had to add some dependencies between lightblue-core modules, pls verify. |
* @author mpatercz | ||
* | ||
*/ | ||
public interface Sequance { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sequence, not Sequance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed :)
0c073f9
to
250aee8
Compare
Squashed commits to hide all the back and forth. Defined Sequence and SequenceSupport as generics (expecting one implementation per kind of sequence). |
ValueGenerators parsing and json schema changes
Metadata changes for lightblue-platform/lightblue#22. Without sequences implementation in lightblue-mongo, this does nothing. It should be merged together with lightblue-mongo changes.