Refactor publish hook configuration and event collection #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue-esb-hook into use-doc-entityName
|
After chatting with @vritant it sounds like part of the confusion is coming from the fact that both lightblue and esb refer to their data models as 'entities'. So what was originally created to refer to the lightblue entity was retasked to being the esb entity which confused me. So I think we need to come up with a way to refer to both types of entities that does not step on eachother. |
Closed
|
Further chatted with @jewzaam and he confirmed that we want to have both entityName (as in lightblue) and [esb]EntityName. |
dcrissman
changed the title
|
@vritant ready for code review. changes are as we discussed. |
vritant
added a commit
that referenced
this pull request
Jul 27, 2015
Refactor publish hook configuration and event collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I am missing something, I don't know why we would want/need the publish hook definition to require the entityName when it already has access to that from the Document.
This PR makes this change and cleans up the unit tests.