Updated tests to use getLightblueFactory() #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcrissman I merged that PR, merged master to this PR, and local builds still fail. |
| @@ -8,6 +8,6 @@ | |||
| "objectClass": ["top", "groupofNames"], | |||
| "cn": "#cn", | |||
| "description": "#description", | |||
| "member": [#members] | |||
| "member": ["#members"] | |||
| } | |||
There was a problem hiding this comment.
This change needs to be reverted. The test methods themselves are ensuring the quotation marks. I am fine if we want to change this, but lets do it in another issue/PR.
There was a problem hiding this comment.
That, or I suppose the unit tests could be changed to not include the surrounding quotation marks.
There was a problem hiding this comment.
Will revert, created #65 to fix
|
Issues should be fixed now, local build is successful at least.. ready for review. |
dcrissman
added a commit
that referenced
this pull request
Mar 31, 2015
Updated tests to use getLightblueFactory()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightblue-platform/lightblue-core#355 being merged.
Local builds are failing but not because of anything I changed.
@dcrissman if this still fails here, might need your eyes on it. It's complaining when trying to create metadata from test resource
metadata/datatype-metadata.json.