Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing Issue with NamedParameterStatement #75

Closed
skavanagh opened this issue Nov 3, 2014 · 2 comments · Fixed by #107
Closed

Licensing Issue with NamedParameterStatement #75

skavanagh opened this issue Nov 3, 2014 · 2 comments · Fixed by #107
Assignees
Milestone

Comments

@skavanagh
Copy link

At a glance much of the implementation is copied from

https://github.com/bnewport/Samples/blob/master/wxsutils/src/main/java/com/devwebsphere/jdbc/loader/NamedParameterStatement.java

which looks to have a non-permissive license
https://github.com/bnewport/Samples/blob/master/wxsutils/LICENSE

This sample program is provided AS IS and may be used, executed, copied and
modified without royalty payment by customer (a) for its own instruction and 
study, (b) in order to develop applications designed to run with an IBM 
WebSphere product, either for customer's own internal use or for redistribution 
by customer, as part of such an application, in customer's own products. "

5724-J34 (C) COPYRIGHT International Business Machines Corp. 2009
All Rights Reserved * Licensed Materials - Property of IBM

You could switch to use this one... https://github.com/colloquium/spacewalk/blob/d4bee4ec00fc89e00dd5c74a684298ebf0e2f686/java/code/src/com/redhat/rhn/common/db/NamedPreparedStatement.java
Looks like a new implementation under GPLv2

@luan-cestari
Copy link
Collaborator

I think we can change the implementation. I would consider the validation that checks if the colon (used to define the variable) is not inside of a string (surrounding by quotes). The reference of the class to be changed https://github.com/lightblue-platform/lightblue-rdbms/blob/master/metadata/src/main/java/com/redhat/lightblue/metadata/rdbms/converter/NamedParameterStatement.java

@luan-cestari luan-cestari added this to the Ana milestone Jan 28, 2015
luan-cestari added a commit to luan-cestari/lightblue-rdbms that referenced this issue Jan 28, 2015
@luan-cestari luan-cestari mentioned this issue Jan 28, 2015
@luan-cestari luan-cestari self-assigned this Jan 28, 2015
@luan-cestari
Copy link
Collaborator

#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants