Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #102 (tests included) #106

Merged
merged 2 commits into from
Jan 28, 2015

Conversation

luan-cestari
Copy link
Collaborator

This pR aims to fix #102

@bserdar
Copy link
Contributor

bserdar commented Jan 27, 2015

The part in processDynVar

  • } else if (o instanceof java.sql.Date) {

is unnecessary. java.sql.Date extends java.util.Date, that block will never execute

@bserdar
Copy link
Contributor

bserdar commented Jan 27, 2015

This is also probably related to #73. You are not using metadata type information while processing fields.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.59%) to 73.37% when pulling 5deefb7 on luan-cestari:issue102 into 0807f6d on lightblue-platform:master.

@luan-cestari luan-cestari mentioned this pull request Jan 28, 2015
@luan-cestari
Copy link
Collaborator Author

@bserdar Fixed the point of code about Date you mentioned. About #73, I think this PR is for the #102 , so the changes #73 should be another PR (maybe it will depend on the changes of this PR, but either way, we check the consistency of the PR for the issue it aims to solve (not all the issues the project have or will have) )

@luan-cestari luan-cestari changed the title Fixed issue #102 (tests included) Fixes issue #102 (tests included) Jan 28, 2015
@luan-cestari
Copy link
Collaborator Author

@derek63 @bserdar this PR pending to be merged to fix issue #102 (IDK if you guys saw that one of jobs failed but if you see the log it showed that it was a problem fetching one jar due timeout. that problem occurs time to time in different branches, for your information (as you can encounter this issue again))

@coveralls
Copy link

Coverage Status

Coverage increased (+4.67%) to 73.44% when pulling 975c3b3 on luan-cestari:issue102 into 0807f6d on lightblue-platform:master.

bserdar added a commit that referenced this pull request Jan 28, 2015
@bserdar bserdar merged commit 44c75f8 into lightblue-platform:master Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.sql.Date to Timestamp Conversion error
3 participants