Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonar.sh to fail if rhc port-forward fails #11

Closed
jewzaam opened this issue Nov 17, 2014 · 3 comments
Closed

Update sonar.sh to fail if rhc port-forward fails #11

jewzaam opened this issue Nov 17, 2014 · 3 comments

Comments

@jewzaam
Copy link
Member

jewzaam commented Nov 17, 2014

If you have multiple servers configured for openshift in rhc command the sonar.sh script should handle the case when you have the wrong server used for the port-forward. Right now it fails to do the port forward but the builds continue but are not able to publish. So unless you're paying attention you might not notice.

@jewzaam jewzaam added the bug label Nov 17, 2014
@jewzaam
Copy link
Member Author

jewzaam commented Nov 17, 2014

The change should be added to the sonar.sh in each individual repo as well, but I don't want to put in issues for that...

@jewzaam
Copy link
Member Author

jewzaam commented Dec 1, 2014

Updated title to generalize that sonar.sh should fail if port forwarding is not successful.

Other way it can fail is if you need to authenticate with rhc command.

@jewzaam jewzaam changed the title Update sonar.sh to handle rhc servers Update sonar.sh to fail if rhc port-forward fails Dec 1, 2014
@jewzaam jewzaam added the ready label Dec 5, 2014
@luan-cestari luan-cestari self-assigned this Feb 10, 2015
@luan-cestari
Copy link
Collaborator

Made a suggestion on #20 . I think we could also evaluate the exit code returned from mvn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants