Fixes #11 - Update sonar.sh to fail if rhc port-forward fails #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # wait a bit for port forwarding to fire up | ||
| sleep 10 | ||
|
|
||
| # if the file exists, log the error and exit 1 | ||
| if [ -f "rhc-port-forward-status" ] |
There was a problem hiding this comment.
This check can come before the sleep 10 above so the script fails faster.
There was a problem hiding this comment.
I don't think we should do that as the '&' would make the process run asynchronously in background , which it can take some time even to connect to the openshift, so the rhc command could not make the result in time to the if statement gives the right/expected output
|
Updated the commented line |
|
Two things to clean up:
|
The etc/sonar.sh will try to remove the file it created before it exit. .gitignore was also updated to ignore the mark file
|
Let me know if I can make the change across the other repositories |
jewzaam
added a commit
that referenced
this pull request
Feb 10, 2015
Fixes #11 - Update sonar.sh to fail if rhc port-forward fails
|
Go for it. Should be an exact copy of this script (plus .gitignore updates) right? |
This was referenced Feb 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info #11