Support multi-key querying with complex keys (issue #54) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,6 +96,18 @@ public void byComplexKey() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void byComplexKeys() { | |||
| List<int[]> keysToGet = new Vector<int[]>(); | |||
There was a problem hiding this comment.
I know this is just a test and doesn't need changing. But in Java you're generally better off using an ArrayList rather than a Vector because most code doesn't need the synchronization that Vector provides.
There was a problem hiding this comment.
You are right. But as you said this is just a test so I'm not going to invest more time in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #54
(Tested)