fix: incorrect default table calc type (#9888)

lightdash · Apr 25, 2024 · 3ddaa89 · 3ddaa89
1 parent de0dfb1
commit 3ddaa89
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/common/src/compiler/filtersCompiler.ts b/packages/common/src/compiler/filtersCompiler.ts
@@ -347,7 +347,7 @@ export const renderTableCalculationFilterRuleSql = (
         case TableCalculationType.BOOLEAN:
             return renderBooleanFilterSql(fieldSql, filterRule);
         default:
-        // Try with format.type for backwards compatibility
+        // Do nothing here. This will try with format.type for backwards compatibility
     }
 
     switch (field.format?.type) {

diff --git a/packages/frontend/src/hooks/echarts/useEchartsCartesianConfig.ts b/packages/frontend/src/hooks/echarts/useEchartsCartesianConfig.ts
@@ -79,6 +79,7 @@ const getLabelFromField = (fields: ItemsMap, key: string | undefined) => {
 
 const getAxisTypeFromField = (item?: ItemsMap[string]): string => {
     if (item && isCustomDimension(item)) return 'category';
+    if (item && isTableCalculation(item) && !item.type) return 'value';
     if (item && (isField(item) || isTableCalculation(item))) {
         switch (item.type) {
             case TableCalculationType.NUMBER: