Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming table calculation with sort causes error #2896

Closed
TuringLovesDeathMetal opened this issue Aug 8, 2022 · 1 comment · Fixed by #2899
Closed

renaming table calculation with sort causes error #2896

TuringLovesDeathMetal opened this issue Aug 8, 2022 · 1 comment · Fixed by #2899
Assignees
@rephus
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience released
Projects
Selected for Development

Comments

@TuringLovesDeathMetal
Copy link
Contributor

Description

If you have a table calculation and you use it to sort your data, then you rename your table calculation, the first label stays in the SQL, so it causes an error when it's rerun.

https://www.loom.com/share/6191c6023e204b61bf58a4d57daa551c

To Reproduce

  1. create a table calculation
  2. add a sort to the table calculation
  3. rename the table calculation
  4. try to rerun the query
@TuringLovesDeathMetal TuringLovesDeathMetal added the 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience label Aug 8, 2022
@TuringLovesDeathMetal TuringLovesDeathMetal added this to 📝 To do in Selected for Development via automation Aug 8, 2022
@rephus rephus moved this from 📝 To do to ⏳ In progress in Selected for Development Aug 9, 2022
@rephus rephus self-assigned this Aug 9, 2022
@rephus rephus mentioned this issue Aug 9, 2022
Merged
Selected for Development automation moved this from ⏳ In progress to ✅ Done Aug 10, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.209.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rephus rephus

Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience released
Projects
No open projects
Selected for Development
✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix table calculation renaming sort lightdash/lightdash
2 participants
@rephus @TuringLovesDeathMetal