Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix table calculation renaming sort #2899

Merged
merged 2 commits into from Aug 10, 2022

Conversation

rephus
Copy link
Collaborator

@rephus rephus commented Aug 9, 2022

Closes: #2896

Description:

Peek 2022-08-09 09-25

@owlas owlas requested a deployment to fix/fix-table-calculation-rename-sort - jaffle_db PR #2899 August 9, 2022 07:27 — with Render Abandoned
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit b6cd489
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/62f22a8b38364100083fb993

@ZeRego ZeRego self-requested a review August 9, 2022 08:30
Copy link
Contributor

@ZeRego ZeRego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort needs to be removed as well well when table calc is deleted.

Maybe we could move the logic to the exploreprovider, in the reducer. We have similar logic to update the sort when the dim/metrics change.

@owlas owlas temporarily deployed to fix/fix-table-calculation-rename-sort - lightdash PR #2899 August 9, 2022 09:36 — with Render Destroyed
@rephus rephus requested a review from ZeRego August 9, 2022 09:49
Copy link
Contributor

@ZeRego ZeRego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 ✅

@rephus rephus merged commit e979b84 into main Aug 10, 2022
@rephus rephus deleted the fix/fix-table-calculation-rename-sort branch August 10, 2022 12:59
github-actions bot pushed a commit that referenced this pull request Aug 10, 2022
## [0.209.3](0.209.2...0.209.3) (2022-08-10)

### Bug Fixes

* fix table calculation renaming sort ([#2899](#2899)) ([e979b84](e979b84))
@github-actions
Copy link

🎉 This PR is included in version 0.209.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renaming table calculation with sort causes error
3 participants