Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zIndex issues on dashboard while loading #10015

Merged

Conversation

magnew
Copy link
Contributor

@magnew magnew commented May 8, 2024

Closes: #9974

Description:

There were some z-Index issues on dashboard while charts were loading. Here is a before and after

Before
before

After*

after

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@magnew magnew requested review from a team and ZeRego and removed request for a team May 8, 2024 12:43
@magnew magnew linked an issue May 8, 2024 that may be closed by this pull request
@owlas owlas requested a deployment to 9974-popovers-get-hidden-behind-loading-tiles-in-dashboards - jaffle_db_pg_13 PR #10015 May 8, 2024 12:43 — with Render Abandoned
@owlas owlas temporarily deployed to 9974-popovers-get-hidden-behind-loading-tiles-in-dashboards - headless-browser PR #10015 May 8, 2024 12:43 — with Render Destroyed
Copy link

netlify bot commented May 8, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 7524818
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/663b73720d33f700082ff9c3

@owlas owlas temporarily deployed to 9974-popovers-get-hidden-behind-loading-tiles-in-dashboards - lightdash PR #10015 May 8, 2024 12:44 — with Render Destroyed
@magnew magnew merged commit 5175c62 into main May 9, 2024
48 of 52 checks passed
@magnew magnew deleted the 9974-popovers-get-hidden-behind-loading-tiles-in-dashboards branch May 9, 2024 18:13
lightdash-bot pushed a commit that referenced this pull request May 9, 2024
## [0.1090.4](0.1090.3...0.1090.4) (2024-05-09)

### Bug Fixes

* zIndex issues on dashbaord while loading ([#10015](#10015)) ([5175c62](5175c62))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1090.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popovers get hidden behind loading tiles in dashboards
4 participants