-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dbt 1.8 #10180
feat: dbt 1.8 #10180
Conversation
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
try { | ||
return JSON.parse(line).unique_id; | ||
} catch { | ||
// ignore non-json lines | ||
return ''; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dbt is throwing deprecation warnings, even with --quiet
, which were causing an error.
"definitions": { | ||
"LightdashNodeConfig": { | ||
"allOf": [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that here we usually extend the dbt definition.
They have changed the manifest json schema https://schemas.getdbt.com/dbt/manifest/v12.json
to use draft 2020-12 https://json-schema.org/draft/2020-12/schema
format.
I couldn't find a way to extend these definitions.
Let me know if there is a way. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I don't think it's that straightforward unless specific referencing is done 👍
const ajv = new Ajv2020(); | ||
ajv.addMetaSchema(draft7MetaSchema); // add backward compatibility with draft-07 | ||
ajv.addSchema([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
draft 2020 is not compatible with draft 07 https://ajv.js.org/json-schema.html#draft-2020-12
So we need to initialize AVJ2020 and add draft 07 meta schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
# [0.1103.0](0.1102.3...0.1103.0) (2024-05-24) ### Features * dbt 1.8 ([#10180](#10180)) ([379e902](379e902))
🎉 This PR is included in version 0.1103.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes: #10034
This PR only offers partial support!
We are going to monitor these adaptors and support them when possible.
Reviewer actions