Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom labels for explores, tables, dimensions and metrics #1061

Merged
merged 8 commits into from
Jan 5, 2022

Conversation

ZeRego
Copy link
Contributor

@ZeRego ZeRego commented Dec 23, 2021

Pre requirements:

Reference:

Closes: #857 #1021

Description:

Support custom labels for:

  • explores ( currently same as the table label )
  • tables
  • dimensions
  • metrics

It also supports the dbt metric label value.

Preview:

schema.yml

  - name: orders
    
    meta:
      label: My orders         <-- Custom table label 

    columns:
      - name: order_id
        meta:
          dimension:
            label: My order ID         <-- Custom dimension label 
          metrics:
            unique_order_count:
              label: My count distinct        <-- Custom metric label 
              type: count_distinct

Screenshot 2022-01-05 at 10 35 56

Scope of the changes (select all that apply):

  • Frontend
  • Backend
  • Common

@owlas owlas requested a deployment to support-labels - jaffle_db PR #1061 December 23, 2021 13:41 — with Render Abandoned
@netlify
Copy link

netlify bot commented Dec 23, 2021

✔️ Deploy Preview for peaceful-bassi-cbf284 canceled.

🔨 Explore the source changes: f6d5909

🔍 Inspect the deploy log: https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/61d57533b22b900007a45d43

@ZeRego ZeRego linked an issue Jan 5, 2022 that may be closed by this pull request
@owlas owlas temporarily deployed to support-labels - lightdash PR #1061 January 5, 2022 10:38 — with Render Destroyed
@ZeRego ZeRego changed the title wip: add labels to explores, tables, dimensions and metrics feat: support custom labels for explores, tables, dimensions and metrics Jan 5, 2022
@ZeRego ZeRego marked this pull request as ready for review January 5, 2022 10:39
@ZeRego ZeRego requested a review from owlas January 5, 2022 10:48
@ZeRego ZeRego merged commit 38e28fe into main Jan 5, 2022
@ZeRego ZeRego deleted the support-labels branch January 5, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set a display label for metrics with dbt metrics Give models user-friendly display names
2 participants