New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grouping dimensions and metrics #2680
Conversation
✅ Deploy Preview for peaceful-bassi-cbf284 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Does this also let you search by the group name in the sidebar? |
Does this only allow for one level of grouping? Could we allow for something like this:
|
Are we able to order groups? |
@hamzahc1 Current implementation only searches dimensions and metrics. How would the search work in that case (both groups and dimensions/metrics? Would it show the group empty if the search matches the group label but doesn't match any of the dimensions inside ?
@Martin-Carlsson Currently yes, this ticket is to provide the basic functionality and after getting feedback, like yours, we will keep improve it.
@Martin-Carlsson Right now it is possible to force the order by prefixing the label with numbers or white spaces. If we want to have configuration for the group labels we might need to add it in the model meta.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, let me test this locally
Closing this ticket as it provides the simplest version of grouping. |
# [0.181.0](0.180.1...0.181.0) (2022-07-13) ### Bug Fixes * edit table calculation ([#2696](#2696)) ([eb0871d](eb0871d)) * filter from table ([#2682](#2682)) ([c2e79bb](c2e79bb)) * format table viz totals ([#2693](#2693)) ([bcd81d7](bcd81d7)) ### Features * grouping dimensions and metrics ([#2680](#2680)) ([10b6740](10b6740))
🎉 This PR is included in version 0.181.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes: #1851
Description:
Changes:
yml example: