Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct state when sql errored #974

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

ZeRego
Copy link
Contributor

@ZeRego ZeRego commented Dec 9, 2021

Closes:

#903

Description:

n/a

Preview:

Screenshot 2021-12-09 at 13 08 15

Scope of the changes (select all that apply):

  • Frontend
  • Backend
  • Common
  • E2E tests
  • Docs
  • CI/CD

@owlas owlas requested a deployment to sql-runner-error-state - jaffle_db PR #974 December 9, 2021 15:38 — with Render Abandoned
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for peaceful-bassi-cbf284 canceled.

🔨 Explore the source changes: 1d995a0

🔍 Inspect the deploy log: https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/61b222e2cb3b950008339d46

@ZeRego ZeRego linked an issue Dec 9, 2021 that may be closed by this pull request
@owlas owlas temporarily deployed to sql-runner-error-state - lightdash PR #974 December 9, 2021 15:39 — with Render Destroyed
@ZeRego ZeRego merged commit 1c03444 into main Dec 9, 2021
@ZeRego ZeRego deleted the sql-runner-error-state branch December 9, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Runner errors show wrong empty state
2 participants