Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix foreign constraint error when add chart to dashboard #9892

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: fix foreign constraint error when add chart to dashboard #9892

merged 1 commit into from
Apr 26, 2024

Conversation

Shifan-Gu
Copy link
Contributor

Closes:

steps to reproduce:

  1. create a saved chart - c1
  2. create a dashboard and add tabs to dashboard - d1
  3. click "add to dashboard" from saved chart

Screenshot 2024-04-25 at 23 28 47
4. then you get the error
Screenshot 2024-04-25 at 23 30 37

Description:

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@netlify Netlify
Copy link

netlify bot commented Apr 25, 2024

👷 Deploy request for peaceful-bassi-cbf284 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 88e9681

@Shifan-Gu Shifan-Gu changed the title fix: fix foreign constriant error when add chart to dashboard fix: fix foreign constraint error when add chart to dashboard Apr 25, 2024
@magnew magnew requested a review from rephus April 26, 2024 10:48
@rephus rephus merged commit 60987e0 into lightdash:main Apr 26, 2024
7 checks passed
lightdash-bot pushed a commit that referenced this pull request Apr 26, 2024
@semantic-release-bot
chore(release): 0.1076.6
b6b84f1 
## [0.1076.6](0.1076.5...0.1076.6) (2024-04-26)

### Bug Fixes

* fix foreign constriant error when add chart to dashboard ([#9892](#9892)) ([60987e0](60987e0))
* The tab delete modal should be more explicit about which tiles/c… ([#9878](#9878)) ([1187081](1187081))
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1076.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rephus rephus rephus approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shifan-Gu @lightdash-bot @rephus