Skip to content

Commit

Permalink
Merge pull request #42 from lightingbeetle/fix/example-t3-modal-not-s…
Browse files Browse the repository at this point in the history
…howing

Fix/example t3 modal not showing
  • Loading branch information
adammockor committed Mar 28, 2023
2 parents 4fdfa0a + 09bdf8d commit dbe1706
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/fast-books-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"example-t3": patch
---

Fix modal not showing
3 changes: 3 additions & 0 deletions packages/example-t3/src/components/Modal/styles/mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
overflow: auto;
-webkit-overflow-scrolling: touch;

// TODO: we have clash of styles comming from @components .modal and .modal in this component - we should idially migrate this modal component to @components to fix this. Until than here are some overrides to make modal work as expected
visibility: visible;

//TODO: could this be replaced with utils.variants?
@each $breakpoint, $props in $settings {
@include tokens.breakpoint($breakpoint) {
Expand Down

2 comments on commit dbe1706

@vercel
Copy link

@vercel vercel bot commented on dbe1706 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on dbe1706 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

next-lighter-example-t3 – ./packages/design-system

next-lighter-example-t3-lighting-beetle.vercel.app
next-lighter-example-t3-git-main-lighting-beetle.vercel.app
next-lighter-example-t3.vercel.app

Please sign in to comment.