Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pysphinx docs version #1289

Merged
merged 3 commits into from Mar 22, 2023
Merged

Fixing pysphinx docs version #1289

merged 3 commits into from Mar 22, 2023

Conversation

christinahedges
Copy link
Collaborator

Fixing the pyproject.toml file to have the correct pydata-sphinx-theme = "==0.8.1" in the correct place.

@christinahedges
Copy link
Collaborator Author

It looks like poetry updated to 1.4.1 this week, and it's causing some issues with continuous integration (e.g. see here). I reverted the PRs I merged this morning (#1282 and #1284) and I'm going to put in some fix for poetry, then I will merge them back in. The tests for those PRs were run before the new poetry version, and so looked good.

@christinahedges
Copy link
Collaborator Author

It looks like as of v1.4.0 poetry has added a new installation method, see here. This seems to not play nicely with our pydata-sphinx-theme installation, and so turning it off in configuration ensures the tests pass. Setting installer.modern-installation to false should give the same behavior from pre v1.4.0.

Because this configuration setting only exists in v1.4.0 or higher, I'm explicitly installing poetry in our github actions as

python -m pip install --upgrade pip 'poetry>=1.4.0'
poetry config installer.modern-installation false

@christinahedges
Copy link
Collaborator Author

It seems like we're getting a ton of timeout messages from our remote tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant