Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightCurveCollection.stitch() should ignore unmergeable columns (fixes #954) #996

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

barentsen
Copy link
Collaborator

This PR addresses #954.

The following snippet of code currently raises an exception because column 'x' is a QColumn in lc1 and a Quantity in lc2:

import lightkurve as lk
from astropy import units as u
lc1 = lk.LightCurve(data={'time': [1,2,3], 'x': [1,2,3]})
lc2 = lk.LightCurve(data={'time': [1,2,3], 'x': [1,2,3]*u.electron/u.second})
lk.LightCurveCollection([lc1, lc2]).stitch()

This PR changes the behavior to exclude column 'x' from the stitch and raise a warning about it.

@barentsen barentsen merged commit a22ef3f into lightkurve:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant