Fix Memory Bank #1009
Merged
Fix Memory Bank #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.42% // Head: 88.42% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 103 103
Lines 4752 4752
=======================================
Hits 4202 4202
Misses 550 550
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add missing assignment after normalizing memory bank. This made the network collapse during training because the norm of the randomly initialized bank was too large. The bug was introduced in #993 (lightly v1.2.37).
How was it tested?
Ran the MoCo Tutorial and verified that the loss decreases.
Closes #1007