Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to collate functions #1079

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

Ra1Nik
Copy link
Contributor

@Ra1Nik Ra1Nik commented Feb 24, 2023

After #1068, the old collate functions will be deprecated. Add deprecation warning.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (64e3f49) 89.14% compared to head (3ea5aa6) 89.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   89.14%   89.16%   +0.01%     
==========================================
  Files         126      126              
  Lines        5327     5334       +7     
==========================================
+ Hits         4749     4756       +7     
  Misses        578      578              
Impacted Files Coverage Δ
lightly/data/collate.py 94.21% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lightly/data/collate.py Outdated Show resolved Hide resolved
Copy link
Contributor

@philippmwirth philippmwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm not approving yet because of the dependency between this PR and the others but you can consider the issue done 👍

@guarin
Copy link
Contributor

guarin commented Mar 21, 2023

@philippmwirth could you approve?

@guarin guarin merged commit a3ea2ff into master Mar 21, 2023
@guarin guarin deleted the niccolo-lig-2587-add-deprecation-warnings-to-collate branch March 21, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants