Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastSiam model #1130

Merged
merged 29 commits into from
Apr 11, 2023
Merged

Add FastSiam model #1130

merged 29 commits into from
Apr 11, 2023

Conversation

philippmwirth
Copy link
Contributor

@philippmwirth philippmwirth commented Apr 4, 2023

Add FastSiam model

Closes #972.

  • Add SimSiam and FastSiam transforms
  • Add FastSiam model to benchmarks

I'll add the examples in a follow-up pull request.

TODO:

  • Imagenette @ 200 epochs
  • Imagenette @ 800 epochs
  • Cifar10 benchmarks
  • Imagenet100 benchmarks

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19 🎉

Comparison is base (b7b6748) 89.35% compared to head (3dccb1a) 89.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   89.35%   89.54%   +0.19%     
==========================================
  Files         129      131       +2     
  Lines        5475     5607     +132     
==========================================
+ Hits         4892     5021     +129     
- Misses        583      586       +3     
Impacted Files Coverage Δ
lightly/transforms/__init__.py 100.00% <100.00%> (ø)
lightly/transforms/fast_siam_transform.py 100.00% <100.00%> (ø)
lightly/transforms/simsiam_transform.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is shorter than expected! Left a few comments :)

@philippmwirth philippmwirth marked this pull request as ready for review April 5, 2023 09:00
Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left two small comments but feel free to resolve and merge.

lightly/transforms/fast_siam_transform.py Outdated Show resolved Hide resolved
@philippmwirth philippmwirth merged commit 9c8cc75 into master Apr 11, 2023
10 checks passed
@philippmwirth philippmwirth deleted the philipp-lig-2589-add-fastsiam-model branch April 11, 2023 08:21
philippmwirth added a commit that referenced this pull request Apr 11, 2023
Follow-up to #1130 adding examples for FastSiam using PyTorch and PyTorch-Lightning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants