-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastSiam model #1130
Add FastSiam model #1130
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
+ Coverage 89.35% 89.54% +0.19%
==========================================
Files 129 131 +2
Lines 5475 5607 +132
==========================================
+ Hits 4892 5021 +129
- Misses 583 586 +3
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that is shorter than expected! Left a few comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left two small comments but feel free to resolve and merge.
Follow-up to #1130 adding examples for FastSiam using PyTorch and PyTorch-Lightning.
Add FastSiam model
Closes #972.
I'll add the examples in a follow-up pull request.
TODO: