Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MoCov2 Transform Parameters #1441

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

guarin
Copy link
Contributor

@guarin guarin commented Dec 4, 2023

Changes

  • Increase min_scale from 0.08 to 0.2
  • Decrease color jitter strengths

Modifies the default parameters for the MoCov2 transform to match the parameters from the original implementation: https://github.com/facebookresearch/moco/blob/5a429c00bb6d4efdf511bf31b6f01e064bf929ab/main_moco.py#L328-L337

* Increase min_scale from 0.08 to 0.2
* Decrease color jitter strengths
@guarin guarin changed the title Fix MoCov2 Transform Fix MoCov2 Transform Parameters Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (caf72c5) 85.24% compared to head (29ad5df) 85.25%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1441   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         130      130           
  Lines        5517     5519    +2     
=======================================
+ Hits         4703     4705    +2     
  Misses        814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@IgorSusmelj IgorSusmelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guarin guarin merged commit 6c36554 into master Dec 5, 2023
10 checks passed
@guarin guarin deleted the guarin-fix-mocov2-transform branch December 5, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants