Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make codecov only run on Python3.10 #1545

Merged
merged 7 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,23 @@ jobs:
- name: Install Dependencies and lightly
run: pip install -e '.[all]'
- name: Clean Previous Coverage Data
if: matrix.python == '3.10'
MalteEbner marked this conversation as resolved.
Show resolved Hide resolved
run: rm -f .coverage
- name: Run Pytest
- name: Run Pytest (Python 3.7)
if: matrix.python == '3.7'
run: |
export LIGHTLY_SERVER_LOCATION="localhost:-1"
pip install pytest-cov==4.1.0
python -m pytest -s -v --runslow --ignore=./lightly/openapi_generated/
- name: Run Pytest with Coverage (Python 3.10)
if: matrix.python == '3.10'
run: |
export LIGHTLY_SERVER_LOCATION="localhost:-1"
pip install pytest-cov==5.0.0
python -m pytest -s -v --runslow --cov=./lightly --cov-report=xml --ignore=./lightly/openapi_generated/
- name: Upload coverage to Codecov
if: matrix.python == '3.10'
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: false
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.CODECOV_TOKEN }}
1 change: 1 addition & 0 deletions tests/utils/test_dist__gather__benchmark_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def close_torch_distributed() -> Generator[None, None, None]:
torch.distributed.destroy_process_group()


@pytest.mark.skip(reason="This test is running in parallel")
guarin marked this conversation as resolved.
Show resolved Hide resolved
class TestGatherLayerBenchmarkModule:
"""
Tests that the gather layer works as expected.
Expand Down
1 change: 1 addition & 0 deletions tests/utils/test_dist__gather__losses.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def close_torch_distributed() -> Generator[None, None, None]:
torch.distributed.destroy_process_group()


@pytest.mark.skip(reason="This test is running in parallel")
guarin marked this conversation as resolved.
Show resolved Hide resolved
class TestGatherLayer_Losses:
"""
Tests that the gather layer works as expected.
Expand Down
Loading