Add proportion_samples to generated api client

[guarin]

Adds api generated code for proportion_samples option.

TODO

• Wait until Add selection config conversion #913 is merged and rebase
• Add docs --> This should actually be done in Malte lig 1262 advanced selection external docs #900

[guarin]

This test no longer makes sense as n_samples is now optional

[MalteEbner]

Could we have two tests instead that checks that both n_samples and proportion_samples can be set?

[guarin]

Oh yes, great catch!

[guarin]

It's actually verified by the test__selection_config_from_dict test.

[codecov]

Codecov Report

Merging #914 (3858722) into master (32338b9) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
+ Coverage   89.22%   89.36%   +0.13%     
==========================================
  Files          97       97              
  Lines        4335     4335              
==========================================
+ Hits         3868     3874       +6     
+ Misses        467      461       -6     

Impacted Files	Coverage Δ
lightly/api/api_workflow_download_dataset.py	92.94% <0.00%> (+7.05%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[MalteEbner]

LGTM

Perhaps you have already though about it, but could we also have the move the_verify_stopping_condition_set() method here and call it before sending the SelectionConfig, e.g. after calling _selection_config_from_dict()?

[guarin]

Perhaps you have already though about it, but could we also have the move the_verify_stopping_condition_set() method here and call it before sending the SelectionConfig, e.g. after calling _selection_config_from_dict()?

I didn't think about it :D But if we do this then the config is only verified if it is set by the pip client. It would not verified if it is set by the API or the webapp.