Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update papermill.cli references to papermill per 2.3.4 release #136

Closed
speediedan opened this issue Jan 27, 2022 · 0 comments 路 Fixed by #137
Closed

Update papermill.cli references to papermill per 2.3.4 release #136

speediedan opened this issue Jan 27, 2022 · 0 comments 路 Fixed by #137
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@speediedan
Copy link
Contributor

馃悰 Bug

With the latest papermill release (2.3.4, updated 2022.01.22), a PR has been included that necessitates a change in our papermill.cli references to papermill

To Reproduce

As part of the make ipynb process, you'll notice python -m papermill.cli {ipynb_file} {pub_ipynb} --kernel python fails. Updating it to python -m papermill {ipynb_file} {pub_ipynb} --kernel python succeeds. In the PR I'm submitting to fix this, I'm also updating requirements to ensure papermill >=2.3.4 as previously, papermill.cli was necessary.

Expected behavior

make ipynb process should generate the relevant executed notebooks

Additional context

The improvement to papermill was originally made by @Borda and now is finally available. Thanks!

@speediedan speediedan added bug / fix Something isn't working help wanted Extra attention is needed labels Jan 27, 2022
@Borda Borda closed this as completed in #137 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant