This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Adjust papermill references for the release of 2.3.4 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Jan 27, 2022
Contributor
|
@speediedan seems that is something odd with git, could you rebase on master? |
auto-merge was automatically disabled
February 6, 2022 20:54
Head branch was pushed to by a user without write access
speediedan
force-pushed
the
papermill_ref_update
branch
from
cf9ec46 to
dad9e1a
Compare
…atest version is used in reqs
speediedan
force-pushed
the
papermill_ref_update
branch
from
dad9e1a to
ba6f7af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #136 .
With the latest papermill release (2.3.4, updated 2022.01.22), a PR has been included that necessitates a change in our papermill.cli references to papermill
As part of the
make ipynbprocess, you'll noticepython -m papermill.cli {ipynb_file} {pub_ipynb} --kernel pythonfails. Updating it topython -m papermill {ipynb_file} {pub_ipynb} --kernel pythonsucceeds.In this PR I'm submitting to fix this, I'm also updating requirements to ensure papermill >=2.3.4 as previously,
papermill.cliwas necessary.The improvement to papermill was originally made by @Borda and now is finally available. Thanks!
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃