Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscores, dashes and backticks. #141

Closed
rustyrussell opened this issue Mar 30, 2017 · 0 comments · Fixed by #163
Closed

Underscores, dashes and backticks. #141

rustyrussell opened this issue Mar 30, 2017 · 0 comments · Fixed by #163
Milestone
v1.0

Comments

@rustyrussell
Copy link
Collaborator

We should make all fields consistent: I initially used - instead of _ because _ causes emphasis in markdown. But since we're supposed to surround all references with `` we should be OK.

Currently we have a nasty mix; I prefer _ because I can use those names exactly in the source code.

I've not made a PR, as I don't want to interfere with Real Work.
@rustyrussell rustyrussell added this to the v1.0 milestone Mar 30, 2017
rustyrussell added a commit that referenced this issue Mar 31, 2017
@rustyrussell
tools/extract-formats.py: allow fields with _ in them.
ed107e4 
eg. BOLT 4.

See also: #141

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this issue May 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Backticks underscores and typos rustyrussell/lightning-rfc
1 participant
@rustyrussell