Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOLT 2: upgrade protocol on reestablish #868

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BOLT 2: upgrade protocol on reestablish #868

wants to merge 3 commits into from

Conversation

rustyrussell
Copy link
Collaborator

@rustyrussell rustyrussell commented May 7, 2021 •
edited

This is the simplest upgrade mechanism I could come up with. It's ready for option_anchors_zero_fee_htlc_tx, too.

Note the reason it's on reconnect: whatever we do, we need to handle reconnect during an upgrade attempt, which meant some kind of fallback "where were we up to?" at that point. Simplest to make that "fallback" technique the only technique.

And in practice we don't upgrade software without reconnecting anyway.

@rustyrussell rustyrussell requested a review from t-bast May 7, 2021 03:04
@rustyrussell rustyrussell force-pushed the guilt/upgrade_protocol branch 3 times, most recently from fff174e to 494e54c Compare May 7, 2021 04:34
@t-bast t-bast mentioned this pull request May 10, 2021
Closed
9 tasks
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 14, 2021
@rustyrussell
channel: import upgrade spec.
9049ccf 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 14, 2021
@rustyrussell
channeld: handle upgrade match.
ff41c98 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this pull request May 14, 2021
Merged
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 17, 2021
@rustyrussell
channel: import upgrade spec.
2c6729c 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 17, 2021
@rustyrussell
channeld: handle upgrade match.
a5c0367 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 18, 2021
@rustyrussell
channeld: handle upgrade match.
d637c07 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit to rustyrussell/lightning that referenced this pull request May 26, 2021
@rustyrussell @cdecker
channel: import upgrade spec.
58792f4 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit to rustyrussell/lightning that referenced this pull request May 26, 2021
@rustyrussell @cdecker
channeld: handle upgrade match.
942875a 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit to rustyrussell/lightning that referenced this pull request May 26, 2021
@rustyrussell @cdecker
channel: import upgrade spec.
a6da78d 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit to rustyrussell/lightning that referenced this pull request May 26, 2021
@rustyrussell @cdecker
channeld: handle upgrade match.
7ee6772 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 31, 2021
@rustyrussell
channel: import upgrade spec.
5be0d20 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request May 31, 2021
@rustyrussell
channeld: handle upgrade match.
be81073 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 1, 2021
@rustyrussell
channeld: handle upgrade match.
bc299ce 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 1, 2021
@rustyrussell
channel: import upgrade spec.
3504aad 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 1, 2021
@rustyrussell
channeld: handle upgrade match.
9499652 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channel: import upgrade spec.
a4153e2 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channeld: handle upgrade match.
763aadb 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channel: import upgrade spec.
3d8c4a1 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channeld: handle upgrade match.
60b5433 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channel: import upgrade spec.
4796f4a 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 3, 2021
@rustyrussell
channeld: handle upgrade match.
c358509 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 4, 2021
@rustyrussell
channel: import upgrade spec.
436197f 
See lightning/bolts#868

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Jun 4, 2021
@rustyrussell
channeld: handle upgrade match.
640e3a1 
We don't actually set desired_type yet, but this handles it.

Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this pull request Jun 12, 2021
Closed
rustyrussell added a commit to rustyrussell/lightning-rfc that referenced this pull request Jun 21, 2021
@rustyrussell
BOLT 2: define channel_type, make negotiation explicit.
fbbdf5b 
This is extracted from channel_upgrade (lightning#868), but used for opening
negotiation as suggested by @Roasbeef on the last spec meeting.

It's a trivial change, fully backwards compatible, but now each channel
has a channel_type, which defines its behavior, rather than an ad-hoc
set of "sticky" feature bits.  It also means both peers can *support* a
feature without endorsing it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this pull request Jun 21, 2021
Merged
rustyrussell added a commit to rustyrussell/lightning-rfc that referenced this pull request Aug 31, 2021
@rustyrussell
BOLT 2: define channel_type, make negotiation explicit.
27de157 
This is extracted from channel_upgrade (lightning#868), but used for opening
negotiation as suggested by @Roasbeef on the last spec meeting.

It's a trivial change, fully backwards compatible, but now each channel
has a channel_type, which defines its behavior, rather than an ad-hoc
set of "sticky" feature bits.  It also means both peers can *support* a
feature without endorsing it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit that referenced this pull request Aug 31, 2021
@rustyrussell
BOLT 2: define channel_type, make negotiation explicit.
4372f9d 
This is extracted from channel_upgrade (#868), but used for opening
negotiation as suggested by @Roasbeef on the last spec meeting.

It's a trivial change, fully backwards compatible, but now each channel
has a channel_type, which defines its behavior, rather than an ad-hoc
set of "sticky" feature bits.  It also means both peers can *support* a
feature without endorsing it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell changed the title BOLT 2: upgrade protocol on reestablish (option_upgrade_channel 34/35) BOLT 2: upgrade protocol on reestablish Sep 30, 2021
@rustyrussell
Copy link
Collaborator Author

Rebased and further simplified.

@rustyrussell rustyrussell force-pushed the guilt/upgrade_protocol branch 2 times, most recently from 427d950 to 7be9947 Compare September 30, 2021 06:22
@TheBlueMatt
Copy link
Collaborator

Concept ACK, can we drop it being based on quiescence? Seems like we can parallelize those efforts.

@rustyrussell
BOLT 2: upgrade protocol on reestablish.
836ee95 
This is the simplest upgrade mechanism I could come up with.  It's
ready for option_anchors_zero_fee_htlc_tx, too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


Header from folded patch 'spell-out-upgrades.patch':

upgrade: spell out upgrade possibilities.

This uses explicit "channel types", which are now merged into master.

Also spell out the potential issues with back-to-back upgrades, and
workarounds if you were to even have this issue.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>


Header from folded patch 'remove-channel-subtype.patch':

BOLT 2: remove channel_type subtype, only allow one upgrade.

We also define channel type elsewhere, so we can remove the
now-outdated one.  And clarify the example.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
features: add explicit option_upgradable.
900be99 
This makes it clear who supports it.  Also point out that it can be
used to enable anchors, and remove link to quiescence protocol, since
this is no longer dependent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
BOLT 1: define what offered and negotiated mean.
084402f 
i.e. it was present in the init feature bits.  We use this in several places, but assume everyone knows what it means.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Collaborator Author

Rebased, and added an explicit feature bit. As a bonus I threw in a commit which defined what "negotiated" and "offered" mean for features!

@t-bast t-bast mentioned this pull request Sep 21, 2023
Closed
24 tasks
@t-bast t-bast mentioned this pull request Oct 5, 2023
Closed
22 tasks
@t-bast t-bast mentioned this pull request Oct 30, 2023
Closed
20 tasks
@t-bast t-bast mentioned this pull request Nov 16, 2023
Closed
20 tasks
@t-bast t-bast mentioned this pull request Dec 4, 2023
Closed
20 tasks
@t-bast t-bast mentioned this pull request Dec 13, 2023
Closed
20 tasks
@t-bast t-bast mentioned this pull request Jan 8, 2024
Closed
21 tasks
@t-bast t-bast mentioned this pull request Jan 22, 2024
Closed
19 tasks
@t-bast t-bast mentioned this pull request Feb 5, 2024
Closed
22 tasks
@t-bast t-bast mentioned this pull request Feb 21, 2024
Closed
21 tasks
@t-bast t-bast mentioned this pull request Mar 7, 2024
Closed
21 tasks
@t-bast t-bast mentioned this pull request Mar 20, 2024
Closed
21 tasks
@Roasbeef Roasbeef mentioned this pull request Apr 8, 2024
Closed
21 tasks
@t-bast t-bast mentioned this pull request Apr 18, 2024
Closed
22 tasks
@t-bast t-bast mentioned this pull request May 2, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast Awaiting requested review from t-bast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rustyrussell @TheBlueMatt