clarification: strict validation of scid for blinded payments #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates bolt04 to more strictly enforce that encrypted_data that is part of a blinded payment only has short_channel_id set. On the reader side, we disallow setting of both short_channel_id and next_node_id (which is intended for use in the context of onion messages), and on the writer side we specify that next_node_id should not be included by recipients.
t-bast
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates bolt04 to more strictly enforce that
encrypted_data that is part of a blinded payment only hasshort_channel_idset. On the reader side, we disallow setting of bothshort_channel_idandnext_node_id(which is intended for use in the context of onion messages), and on the writer side we specify thatnext_node_idshould not be included by recipients.h/t: @ellemouton for flagging during review!