BOLT 9: add features wumbo and wumborama #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about renaming:
It is a bit less fun but also more self explaining. We can still keep the wumbo nickname :-). |
niftynei
reviewed
Apr 1, 2019
| @@ -165,14 +165,18 @@ The `shutdown_scriptpubkey` allows the sending node to commit to where | |||
| funds will go on mutual close, which the remote node should enforce | |||
| even if a node is compromised later. | |||
|
|
|||
| [ FIXME: Describe dangerous feature bit for larger channel amounts. ] | |||
| The `option_i_wumbo_you_wumbo` allows peers to signal that they will accept | |||
| `funding_satoshis` greater than 2^24. | |||
There was a problem hiding this comment.
also mention option_wumborama here?
| @@ -108,6 +108,7 @@ The sending node: | |||
| - MUST set feature bits as defined in [BOLT #9](09-features.md). | |||
| - MUST set any undefined feature bits to 0. | |||
| - SHOULD use the minimum lengths required to represent the feature fields. | |||
| - MUST set local feature `option_i_wumbo_you_wumbo` if `option_wumborama` is set in global features. | |||
There was a problem hiding this comment.
this seems like an odd place to add this requirement. this restriction applies to the wumbo bit featureset, not to the global/localfeatures requirements. i'd move this to the Requirements section in features.
|
|
||
| #### Requirements | ||
|
|
||
| The sending node: | ||
| - MUST ensure the `chain_hash` value identifies the chain it wishes to open the channel within. | ||
| - MUST ensure `temporary_channel_id` is unique from any other channel ID with the same peer. | ||
| - MUST set `funding_satoshis` to less than 2^24 satoshi. | ||
| - if both nodes advertised `option_i_wumbo_you_wumbo`: | ||
| - MAY set `funding_satoshis` greater than 2^24 satoshi. |
There was a problem hiding this comment.
Suggested change
| - MAY set `funding_satoshis` greater than 2^24 satoshi. | |
| - MAY set `funding_satoshis` greater than or equal to 2^24 satoshi. |
| @@ -216,15 +220,15 @@ are not valid DER-encoded compressed secp256k1 pubkeys. | |||
| - `dust_limit_satoshis` is greater than `channel_reserve_satoshis`. | |||
| - the funder's amount for the initial commitment transaction is not sufficient for full [fee payment](03-transactions.md#fee-payment). | |||
| - both `to_local` and `to_remote` amounts for the initial commitment transaction are less than or equal to `channel_reserve_satoshis` (see [BOLT 3](03-transactions.md#commitment-transaction-outputs)). | |||
| - `funding_satoshis` is greater than 2^24 and the receiver does not support `option_i_wumbo_you_wumbo`. | |||
There was a problem hiding this comment.
Suggested change
| - `funding_satoshis` is greater than 2^24 and the receiver does not support `option_i_wumbo_you_wumbo`. | |
| - `funding_satoshis` is greater than or equal to 2^24 and the receiver does not support `option_i_wumbo_you_wumbo`. |
| It can be lifted at any point in time, or adjusted for other currencies, since it is solely enforced by the endpoints of a channel. | ||
| Specifically, [the routing gossip protocol](07-routing-gossip.md) does not discard channels that have a larger capacity. | ||
| The requirement for `funding_satoshis` to be less than 2^24 satoshi was a temporary self-imposed limit while implementations were not yet considered stable. | ||
| , it can be lifted by advertising `option_i_wumbo_you_wumbo`. |
There was a problem hiding this comment.
Technically option_wumborama would have been used to advertise that you will support option_i_wumbo_you_wumbo, anyway I'm going to change this PR to use a single option (since there was some agreement at the last meeting)
|
There's some overlap with this and #571 |
|
Closing as this is replaced by #596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal formalizes the discussion happened on the mailing list about lifting the channel size limit. Two features are defined here:
option_i_wumbo_you_wumbomeans I'm willing to accept channel larger than 2^24 (local feature)option_wumboramameans I offer and I'm willing to acceptoption_i_wumbo_you_wumbofrom anyone (global feature)Peers MUST set
option_i_wumbo_you_wumboin the local features of theinitmessage if they set theoption_wumboramain the global features, the proposal reuses the bits defined in #571