BOLT 11: make UPPERCASE explicit. #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
approved these changes
Sep 30, 2019
rustyrussell
added a commit
to rustyrussell/lightning-rfc
that referenced
this pull request
Feb 2, 2020
One for uppercase, and one with should-be-ignored fields. The first of these addresses lightning#659 (lightning#677 directly changes the text to make it clear this is allowed, and should also be applied). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning-rfc
that referenced
this pull request
May 11, 2020
One for uppercase, and one with should-be-ignored fields. The first of these addresses lightning#659 (lightning#677 directly changes the text to make it clear this is allowed, and should also be applied). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
12 tasks
|
ACK 9a84c66 |
t-bast
approved these changes
Aug 3, 2020
Aren't they just uppercased versions of the previous vectors? |
Explicitly mirror the BIP-173 advice for QR codes, and note the reader requirements. Fixes: lightning#659 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
bolt11-uppercase
branch
from
abe91b7
to
fa188db
Compare
|
Rebased without test vector change, since spec has since included an upper-case vector. |
t-bast
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly mirror the BIP-173 advice for QR codes, and note the reader
requirements. In addition, we change the case of one of the examples
to ensure testing.
Fixes: #659
Alternative-to: #661